[ConstraintSystem] Use fallback type constraint to default pack expansion#66708
Merged
xedin merged 2 commits intoswiftlang:mainfrom Jun 19, 2023
Merged
Conversation
Contributor
Author
|
@swift-ci please test |
hborla
approved these changes
Jun 16, 2023
Contributor
Author
|
@swift-ci please test source compatibility |
This constraint is useful in more places than closures because it gives a way to provide a "fallback type" without it having effect on inference.
…sion Binding of pack expansion types is delayed until solving but use of `Defaultable` was preventing it from being considered early because that constraint impacts binding set ranking, switching to `FallbackType` constraint give us better semantics where pack expansion type variables are going to be bound as soon as they have a contextual type. Resolves: rdar://110819621
xedin
force-pushed
the
generalize-default-closure-type-constraint
branch
from
4823bf2 to
83bb9c1
Compare
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalizes
DefaultClosureTypeintoFallbackTypeconstraint.Binding of pack expansion types is delayed until solving but use
of
Defaultablewas preventing it from being considered earlybecause that constraint impacts binding set ranking, switching
to
FallbackTypeconstraint give us better semantics where packexpansion type variables are going to be bound as soon as they
have a contextual type.
Resolves: rdar://110819621